Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adding unit test #25

Merged
merged 3 commits into from
Jun 30, 2023
Merged

chore: adding unit test #25

merged 3 commits into from
Jun 30, 2023

Conversation

adriantam
Copy link
Member

@adriantam adriantam commented Jun 28, 2023 •
edited by rhamzeh
Loading

Description

Adding unit tests

References

Part of #7

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@adriantam adriantam requested a review from a team as a code owner June 28, 2023 21:18
@adriantam adriantam marked this pull request as draft June 28, 2023 21:21
@adriantam adriantam force-pushed the chore/ut branch 2 times, most recently from e880eb1 to 984d913 Compare June 28, 2023 23:27
rhamzeh
rhamzeh reviewed Jun 30, 2023
View reviewed changes
cmd/models/list.go Outdated Show resolved Hide resolved
rhamzeh
rhamzeh reviewed Jun 30, 2023
View reviewed changes
cmd/models/write.go Outdated Show resolved Hide resolved
@adriantam adriantam marked this pull request as ready for review June 30, 2023 15:13
@adriantam adriantam requested a review from rhamzeh June 30, 2023 15:13
@adriantam adriantam added this pull request to the merge queue Jun 30, 2023
Merged via the queue into main with commit 40d7005 Jun 30, 2023
10 checks passed
@adriantam adriantam deleted the chore/ut branch June 30, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhamzeh rhamzeh rhamzeh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adriantam @rhamzeh